-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actuator source passive scalar and tagging #1170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbkuhn
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! will be a cool feature.
co-authored by michaeljbrazell
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This revives capability that was showcased in #474 but never merged. This lets us have a passive scalar that is initialized at the actuator source location and advect/diffuse.
All credit goes to @michaeljbrazell for this. I just renamed things and simplified.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
This lets us have a passive scalar that is initialized at the actuator source location and advect/diffuse. We can do 2 things with this:
Here's a demo viz:
This introduces a bunch of knobs:
tagging.tracer.field_error
: what value do you decide is high enough that you should refinetransport.passive_scalar_laminar_schmidt
andtransport.passive_scalar_turbulent_schmidt
for diffusion of this passive scalarActuatorSourceTagging.act_src_threshold
at what source value threshold do we have a unity passive scalarI have no idea what those values should be but we could study that.